Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21673 )
Change subject: [ranger] enhance the robustness of key retrieval ...................................................................... Patch Set 3: (4 comments) http://gerrit.cloudera.org:8080/#/c/21673/3/src/kudu/ranger-kms/ranger_kms_client.cc File src/kudu/ranger-kms/ranger_kms_client.cc: http://gerrit.cloudera.org:8080/#/c/21673/3/src/kudu/ranger-kms/ranger_kms_client.cc@36 PS3, Line 36: ranger nit: Apache Ranger other places are the same. http://gerrit.cloudera.org:8080/#/c/21673/3/src/kudu/ranger-kms/ranger_kms_client.cc@41 PS3, Line 41: period nit: period in seconds http://gerrit.cloudera.org:8080/#/c/21673/3/src/kudu/ranger-kms/ranger_kms_client.cc@113 PS3, Line 113: s = curl.FetchURL(urls, &resp); Print warning logs if failed. http://gerrit.cloudera.org:8080/#/c/21673/3/src/kudu/ranger-kms/ranger_kms_client.cc@117 PS3, Line 117: SleepFor(MonoDelta::FromMilliseconds(300)); There is a backoff utility in rpc module named RpcRetrier::ComputeBackoff(), how about encapsulating a general utility to calculate backoff time interval? -- To view, visit http://gerrit.cloudera.org:8080/21673 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1fd3263ad6ba6d8e444036bb7d2158986098cb4b Gerrit-Change-Number: 21673 Gerrit-PatchSet: 3 Gerrit-Owner: KeDeng <[email protected]> Gerrit-Reviewer: KeDeng <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Fri, 16 Aug 2024 07:09:08 +0000 Gerrit-HasComments: Yes
