Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/21723 )
Change subject: Add Prometheus HTTP service discovery ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/21723/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21723/2//COMMIT_MSG@14 PS2, Line 14: groupped nit: grouped http://gerrit.cloudera.org:8080/#/c/21723/2//COMMIT_MSG@42 PS2, Line 42: I added basic unittest to verify the structure of the JSON. Moreover I nit: unit test http://gerrit.cloudera.org:8080/#/c/21723/2//COMMIT_MSG@67 PS2, Line 67: Promethes data source is working, one can execute qureys and create nit: queries http://gerrit.cloudera.org:8080/#/c/21723/2/src/kudu/master/master_path_handlers.h File src/kudu/master/master_path_handlers.h: http://gerrit.cloudera.org:8080/#/c/21723/2/src/kudu/master/master_path_handlers.h@61 PS2, Line 61: nit: align lines http://gerrit.cloudera.org:8080/#/c/21723/2/src/kudu/master/master_path_handlers.cc File src/kudu/master/master_path_handlers.cc: http://gerrit.cloudera.org:8080/#/c/21723/2/src/kudu/master/master_path_handlers.cc@876 PS2, Line 876: Webserver nit: alignment -- To view, visit http://gerrit.cloudera.org:8080/21723 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I931aa72a7567c0dde43d7b7ed53a2dd0fa8bc1fe Gerrit-Change-Number: 21723 Gerrit-PatchSet: 2 Gerrit-Owner: Marton Greber <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Mon, 26 Aug 2024 14:01:28 +0000 Gerrit-HasComments: Yes
