Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21727 )
Change subject: [rpc] instantiate DiagnosticSocket only if sock_diag available ...................................................................... [rpc] instantiate DiagnosticSocket only if sock_diag available In the review feedback on [1], Yingchun Lai pointed to the fact that the DiagnosticSocket field would be instantiated in AcceptorPool even if the sock_diag netlink facility was not available. An alternative approach would be not instantiating it at all in that case. This patch addresses the point. This is a follow-up to d27603ec7ea6adb4e89c25a37ab1fed314011a47. [1] http://gerrit.cloudera.org:8080/21722 Change-Id: Ic70b6cca94b50f070efbc159a767d207c3a7b230 Reviewed-on: http://gerrit.cloudera.org:8080/21727 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Yingchun Lai <[email protected]> --- M src/kudu/rpc/acceptor_pool.cc M src/kudu/rpc/acceptor_pool.h M src/kudu/util/CMakeLists.txt M src/kudu/util/net/diagnostic_socket.cc 4 files changed, 31 insertions(+), 37 deletions(-) Approvals: Alexey Serbin: Verified Yingchun Lai: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21727 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ic70b6cca94b50f070efbc159a767d207c3a7b230 Gerrit-Change-Number: 21727 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]>
