Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/20307 )
Change subject: WIP [build] introduce NO_JAVA option ...................................................................... Patch Set 2: I like the idea, we'll have to make sure for future java related features that they are enclosed within the !defined(KUDU_NO_JAVA) block. Also, to note, if building offline is a requirement, there is an '--offline' flag in gradle, e.g. `gradle --offline assemble` this will force gradle to use the local cache only, if there are missing dependencies the build will fail. Maybe it would make sense to add a BUILD_OFFILNE option for this scenario (in a different patchset)? -- To view, visit http://gerrit.cloudera.org:8080/20307 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3d59caa3bc718a2f53a798c1e97e367d9f65c5ae Gerrit-Change-Number: 20307 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Wed, 28 Aug 2024 09:53:43 +0000 Gerrit-HasComments: No
