Hello Attila Bukor, Kudu Jenkins, Joe McDonnell,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/21731
to look at the new patch set (#2).
Change subject: [wip][java][build] KUDU-3610: kudu-client.jar dependencies
......................................................................
[wip][java][build] KUDU-3610: kudu-client.jar dependencies
As reported in KUDU-3610 Impala build fails with the newly generated
kudu-client.jar, due to some new runtime dependencies, this patch aims
to restrict those dependencies or remove them if possible.
For comparison here are the generated poms for pre-gradle upgrade and
the one generated by using this change:
https://gist.github.com/zchovan/325eee8ca9fade9bd618547eef6509c4
To summarize the changes:
* before gradle upgrade
[
{
"gId": "com.stumbleupon",
"aId": "async",
"scope": "compile"
},
{
"gId": "org.apache.yetus",
"aId": "audience-annotations",
"scope": "compile"
},
{
"gId": "com.google.code.findbugs",
"aId": "jsr305",
"scope": "compile"
},
{
"gId": "junit",
"aId": "junit",
"scope": "test"
},
{
"gId": "org.apache.kudu",
"aId": "kudu-test-utils",
"scope": "test"
},
{
"gId": "org.apache.logging.log4j",
"aId": "log4j-api",
"scope": "test"
},
{
"gId": "org.apache.logging.log4j",
"aId": "log4j-core",
"scope": "test"
},
{
"gId": "org.apache.logging.log4j",
"aId": "log4j-slf4j-impl",
"scope": "test"
},
{
"gId": "org.mockito",
"aId": "mockito-core",
"scope": "test"
},
{
"gId": "org.slf4j",
"aId": "slf4j-api",
"scope": "compile"
}
]
* after this patch:
[
{
"gId": "com.stumbleupon",
"aId": "async",
"scope": "runtime"
},
{
"gId": "com.google.guava",
"aId": "guava",
"scope": "runtime"
},
{
"gId": "org.apache.kudu",
"aId": "kudu-proto",
"scope": "compile"
},
{
"gId": "io.micrometer",
"aId": "micrometer-core",
"scope": "runtime"
},
{
"gId": "com.sangupta",
"aId": "murmur",
"scope": "runtime"
},
{
"gId": "io.netty",
"aId": "netty-all",
"scope": "runtime"
},
{
"gId": "com.google.protobuf",
"aId": "protobuf-java",
"scope": "compile"
},
{
"gId": "org.slf4j",
"aId": "slf4j-api",
"scope": "runtime"
}
]
Additional manual testing (building Impala) is needed to confirm this
change is sufficient.
Change-Id: I607d7c62c585b2aa1bee4ebf7907309e130092da
---
M java/gradle/publishing.gradle
M java/gradle/shadow.gradle
M java/kudu-client/build.gradle
3 files changed, 79 insertions(+), 48 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/31/21731/2
--
To view, visit http://gerrit.cloudera.org:8080/21731
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I607d7c62c585b2aa1bee4ebf7907309e130092da
Gerrit-Change-Number: 21731
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
