Marton Greber has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/21759 )
Change subject: [rpc] micro-cleanup on InboundCall and ServicePool
......................................................................
[rpc] micro-cleanup on InboundCall and ServicePool
I was troubleshooting an issue and went over the related code
to clean it up a bit:
* don't crash on errors in ServicePool::Init(), but return the status
to be handled at the upper level
* ServicePool::RejectTooBusy() first sends corresponding response
before logging about the rejected request
* fix const-correctness of a few methods in InboundCall, ServicePool
* remove unnecessary mutex primitive in ServicePool
Change-Id: I255754da8e66263a00aa28e9061102d4ec421105
Reviewed-on: http://gerrit.cloudera.org:8080/21759
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Marton Greber <[email protected]>
Reviewed-by: Zoltan Chovan <[email protected]>
---
M src/kudu/rpc/inbound_call.cc
M src/kudu/rpc/inbound_call.h
M src/kudu/rpc/rpcz_store.cc
M src/kudu/rpc/rpcz_store.h
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/service_pool.h
6 files changed, 24 insertions(+), 25 deletions(-)
Approvals:
Alexey Serbin: Verified
Marton Greber: Looks good to me, approved
Zoltan Chovan: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.cloudera.org:8080/21759
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I255754da8e66263a00aa28e9061102d4ec421105
Gerrit-Change-Number: 21759
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
Gerrit-Reviewer: Yingchun Lai <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
