Hello Alexey Serbin,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/21788
to review the following change.
Change subject: [cmake_modules] recognize linker coming with LLVM 15
......................................................................
[cmake_modules] recognize linker coming with LLVM 15
This patch updates the GET_LINKER_VERSION cmake's function to work
with ld linker that comes with LLVM 15 as a part of Xcode 15.3 on macOS.
Without this patch, running cmake in the build directory on macOS
using Xcode 15.3 would fail with an error like below:
-- Checking linker version when not specifying any flags
CMake Error at cmake_modules/KuduLinker.cmake:87 (message):
Could not find a suitable linker
Change-Id: If120b281a44fa7a9b9976d078c34f36ab942f089
Reviewed-on: http://gerrit.cloudera.org:8080/21202
Reviewed-by: Abhishek Chennaka <[email protected]>
Tested-by: Alexey Serbin <[email protected]>
(cherry picked from commit be36cc0e2edd6a73b7e0936f570612d8c724ac24)
---
M cmake_modules/KuduLinker.cmake
1 file changed, 15 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/88/21788/1
--
To view, visit http://gerrit.cloudera.org:8080/21788
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: If120b281a44fa7a9b9976d078c34f36ab942f089
Gerrit-Change-Number: 21788
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
