Hello Attila Bukor, Kudu Jenkins,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/21785
to review the following change.
Change subject: [cmake] Kudu should compile on Mac OS without SDKROOT set.
......................................................................
[cmake] Kudu should compile on Mac OS without SDKROOT set.
Cmake figures out the sdkroot path perfectly without the environment
variable SDKROOT. The only thing that fails is the linker test in
cmake_modules/KuduLinker.cmake. Setting SDKROOT is also missing from
the docs/installation.adoc, although it is mandatory (it should not).
Change-Id: I1cfe84f31238ccb208bdf49e8b05688107dd5ae2
Reviewed-on: http://gerrit.cloudera.org:8080/19935
Tested-by: Kudu Jenkins
Reviewed-by: Attila Bukor <[email protected]>
Tested-by: Attila Bukor <[email protected]>
(cherry picked from commit a119f1b6b473d60bb1e38071e873ff2d5d708062)
---
M cmake_modules/KuduLinker.cmake
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/85/21785/1
--
To view, visit http://gerrit.cloudera.org:8080/21785
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.17.x
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1cfe84f31238ccb208bdf49e8b05688107dd5ae2
Gerrit-Change-Number: 21785
Gerrit-PatchSet: 1
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <[email protected]>
