Yingchun Lai has posted comments on this change. ( http://gerrit.cloudera.org:8080/21779 )
Change subject: [tablet] fix race in RowSetMetadata::id() ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21779/3/src/kudu/tablet/cfile_set.cc File src/kudu/tablet/cfile_set.cc: http://gerrit.cloudera.org:8080/#/c/21779/3/src/kudu/tablet/cfile_set.cc@148 PS3, Line 148: const auto& ins_info = readers_by_col_id_.emplace(col_id, std::move(reader)); : DCHECK(ins_info.second) << "already open"; What about using EmplaceOrDie to simplify the code? http://gerrit.cloudera.org:8080/#/c/21779/3/src/kudu/tablet/rowset_metadata.cc File src/kudu/tablet/rowset_metadata.cc: http://gerrit.cloudera.org:8080/#/c/21779/3/src/kudu/tablet/rowset_metadata.cc@127 PS3, Line 127: void RowSetMetadata::ToProtobuf(RowSetDataPB *pb) { We can set ToProtobuf() as const by the way? -- To view, visit http://gerrit.cloudera.org:8080/21779 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b09575616e754b7dbb24586293f128e361b9360 Gerrit-Change-Number: 21779 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 12 Sep 2024 02:54:47 +0000 Gerrit-HasComments: Yes
