Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21804 )
Change subject: [test] leave generated files on a non-fatal failure as well ...................................................................... [test] leave generated files on a non-fatal failure as well Kudu tests have been leaving generated files in case of a fatal failure (e.g., ASSERT_XXX, FAIL macros, etc.), but not for non-fatal ones (e.g., EXPECT_XXX macros). Tests scenarios that tend to print out all the errors before exiting use EXPECT_XXX macros, and sometimes it might be not a single fatal failure generated, but many non-fatal ones. This patch updates the code to leave the generated files if a non-fatal failure is detected as well. Change-Id: Id39b70bd357f47e85f7f9b7b145520b824d5d496 Reviewed-on: http://gerrit.cloudera.org:8080/21804 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Yifan Zhang <[email protected]> --- M src/kudu/util/test_util.cc 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alexey Serbin: Verified Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21804 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id39b70bd357f47e85f7f9b7b145520b824d5d496 Gerrit-Change-Number: 21804 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]>
