Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21695 )
Change subject: KUDU-3606 [tools] Check column IDs when --strict_column_id is enabled ...................................................................... Patch Set 6: Code-Review+1 (3 comments) just a few nits, otherwise LGTM http://gerrit.cloudera.org:8080/#/c/21695/4/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/21695/4/src/kudu/tools/kudu-tool-test.cc@1281 PS4, Line 1281: RETURN_NOT_OK(alterer->DropColumn("to_delete_col1") : ->DropColumn("to_delete_col2") : ->DropColumn("to_delete_col3") : ->DropColumn("to_delete_col4") > It has multiple 'hole' intervals now, they are: Ah, indeed -- I missed that even if it's obvious from lines 1262 -- 1271 http://gerrit.cloudera.org:8080/#/c/21695/6/src/kudu/tools/table_scanner.cc File src/kudu/tools/table_scanner.cc: http://gerrit.cloudera.org:8080/#/c/21695/6/src/kudu/tools/table_scanner.cc@496 PS6, Line 496: must be in monotonic increase order must be monotonically increasing http://gerrit.cloudera.org:8080/#/c/21695/6/src/kudu/tools/table_scanner.cc@497 PS6, Line 497: expect expecting -- To view, visit http://gerrit.cloudera.org:8080/21695 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I77af7b92b45f3866cc8b699e61b9e71b73ed6c4b Gerrit-Change-Number: 21695 Gerrit-PatchSet: 6 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Tue, 17 Sep 2024 23:32:12 +0000 Gerrit-HasComments: Yes
