Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21956 )
Change subject: KUDU-613: Fix minor metrics related bug ...................................................................... Patch Set 1: > (1 comment) Without going much into details, I see the description of this patch states that: '... This patch fixes this bug so now the metrics should be accurate ...' With that, I'd think you know of a scenario where user-facing metrics (i.e. CacheMetrics) were incorrect without this patch, but now they show correct numbers. Is it possible to programmatically implement a simplest scenario where it's be possible to see such a difference with and without the fix? If going into more details a little bit, you could create a test and befriend it to a class that you are testing, and with that you can access any field and downcast anything to whatever you know it actually is. Maybe, then it be possible to capture the missing details, no? -- To view, visit http://gerrit.cloudera.org:8080/21956 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0d2fd44169e1abe642c11e16e4b87aaa971b2d88 Gerrit-Change-Number: 21956 Gerrit-PatchSet: 1 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 24 Oct 2024 05:04:53 +0000 Gerrit-HasComments: No
