[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/21920 )
Change subject: Implement path parameter handling in webserver ...................................................................... Patch Set 6: (1 comment) > Build Failed > > http://jenkins.kudu.apache.org/job/pre_commit/618/ : FAILURE Failing tests seem flaky and unrelated to this change. http://gerrit.cloudera.org:8080/#/c/21920/4/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/21920/4/src/kudu/server/webserver-test.cc@719 PS4, Line 719: ASSERT_EQ("Remote error: HTTP 404", s.ToString()); : } : : // Test that the query string is correctly parsed and returned in the response, : // even when the path contains a path parameter. : T > Is this what we are aiming for? I created this testcase, so that we can test that the path parameter implementation doesn't interfere with query parameters, I realize now this could be confusing, so I am adding comments to explain. -- To view, visit http://gerrit.cloudera.org:8080/21920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2085c55d3b86985c87c5fd5a8b48568f8e6fa63 Gerrit-Change-Number: 21920 Gerrit-PatchSet: 6 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 28 Oct 2024 12:39:42 +0000 Gerrit-HasComments: Yes
