Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21981 )
Change subject: [ARM] Fix CountOnes() function ...................................................................... [ARM] Fix CountOnes() function This function is only used on arms. It does not work on numbers greater than 255: For some reason ULL suffix was added to 2 masks, that should be 32bit, and losing the higher bits are actually the desired behaviour. Change-Id: Ia4b78b5c1df9547548fc7980cec4b84349e868bc Reviewed-on: http://gerrit.cloudera.org:8080/20736 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Kudu Jenkins (cherry picked from commit cda230197d9b25bf635facb29215fcfbdd09c415) Reviewed-on: http://gerrit.cloudera.org:8080/21981 Reviewed-by: Abhishek Chennaka <[email protected]> Tested-by: Alexey Serbin <[email protected]> --- M src/kudu/gutil/bits.h 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Abhishek Chennaka: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/21981 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.17.x Gerrit-MessageType: merged Gerrit-Change-Id: Ia4b78b5c1df9547548fc7980cec4b84349e868bc Gerrit-Change-Number: 21981 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]>
