Marton Greber has posted comments on this change. ( http://gerrit.cloudera.org:8080/21920 )
Change subject: Implement path parameter handling in webserver ...................................................................... Patch Set 9: (3 comments) Just a couple nits. http://gerrit.cloudera.org:8080/#/c/21920/9/src/kudu/server/webserver.h File src/kudu/server/webserver.h: http://gerrit.cloudera.org:8080/#/c/21920/9/src/kudu/server/webserver.h@190 PS9, Line 190: HasNonAscii nit: maybe ContainsNonAscii is a bit better http://gerrit.cloudera.org:8080/#/c/21920/9/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/21920/9/src/kudu/server/webserver.cc@600 PS9, Line 600: has nit: contains http://gerrit.cloudera.org:8080/#/c/21920/9/src/kudu/server/webserver.cc@738 PS9, Line 738: segments.reserve(std::count(path.begin(), path.end(), '/') + : 1); // Reserve space based on '/' count nit: you can just keep the code in a single line and put the comment above it. -- To view, visit http://gerrit.cloudera.org:8080/21920 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id2085c55d3b86985c87c5fd5a8b48568f8e6fa63 Gerrit-Change-Number: 21920 Gerrit-PatchSet: 9 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 31 Oct 2024 16:44:44 +0000 Gerrit-HasComments: Yes
