Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22075 )
Change subject: [cfile] 'null bitmap' --> 'non-null bitmap' ...................................................................... [cfile] 'null bitmap' --> 'non-null bitmap' The corresponding bitmaps have always had the semantics that a set bit indicated a non-null entry. Thus naming any of those as a 'null bitmap' is quite misleading. Also, since changelist [1] renamed a subset of entities already, now it's even more confusing. I think it's never too late to add more clarity, so this patch renames the rest of the entities in the code and also updates the documentation. This patch doesn't contain any functional modifications. This is a follow-up to [1]. [1] https://github.com/apache/kudu/commit/ffef96b26 Change-Id: Ib298b5b6bca786dc69928b960c535f95f177d604 Reviewed-on: http://gerrit.cloudera.org:8080/22075 Tested-by: Kudu Jenkins Reviewed-by: Yifan Zhang <[email protected]> --- M docs/design-docs/cfile.md M src/kudu/cfile/cfile_reader.cc M src/kudu/cfile/cfile_util.cc M src/kudu/cfile/cfile_writer.cc M src/kudu/cfile/cfile_writer.h M src/kudu/common/columnar_serialization.cc M src/kudu/common/columnblock.h M src/kudu/common/row_operations.cc M src/kudu/common/row_operations.h M src/kudu/common/rowblock.h 10 files changed, 46 insertions(+), 40 deletions(-) Approvals: Kudu Jenkins: Verified Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib298b5b6bca786dc69928b960c535f95f177d604 Gerrit-Change-Number: 22075 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]>
