Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22074 )
Change subject: [fs] simplify FsErrorManager ...................................................................... Patch Set 2: Verified+1 > Thanks a lot for review! > > It seems something is screwed up in the lifecycle of FsErrorManager > objects (at least for several tests), where the usual suspect is > bee1283718fda9d9d28455e62501e52f78fbf565. That's became apparent > once replacing Mutex with std::mutex as a member of FsErrorManager. > > I need to clarify on this and post a fix. Ah, I take that back. It turned out the problem was just off-by-one mistake on my own. This is now fixed in PS2. -- To view, visit http://gerrit.cloudera.org:8080/22074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0a6f82f4da173949f2fc40517ebacd34be3a0434 Gerrit-Change-Number: 22074 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Tue, 19 Nov 2024 02:15:26 +0000 Gerrit-HasComments: No
