Zoltan Martonka has uploaded this change for review. (
http://gerrit.cloudera.org:8080/22097
Change subject: Update glog to 0.7.1
......................................................................
Update glog to 0.7.1
Reason:
Glog 0.6.0 does not resolve cold symbols properly.
Stack traces on ARM are now properly handled, and we no longer need to
apply a private patch.
Fixes:
- ARM patch is no longer needed.
- Hidden symbols are no longer forcibly exported.
- GetStackTrace is now public in 0.7.0.
- Symbolize is the only hidden symbol we need to use. Therefore,
we export just that with a patch.
- Logger::Write now uses std::chrono::system_clock::time_point&
instead of time_t. The old Write method does not work. It is marked
as deprecated but completely stops working.
- Custom loggers are now properly deleted instead of leaking memory.
AsyncLogger's destructor must terminate the other threads
(the object was simply leaked in 0.6.0).
- LogSeverity is now a proper enum.
- Glog 0.7.1 (and 0.7.0) crashes if there is a function name longer
than 256 characters, including parameters. This means even a
reasonably long function can cause a crash, for example:
FsManager::AddTenant(const string& tenant_name,
const string& tenant_id,
optional<string> tenant_key,
optional<string> tenant_key_iv,
optional<string> tenant_key_version)
It is a bit unbelievable, but true. The fix is in progress:
https://github.com/google/glog/pull/1137
Until then, we will truncate such strings to avoid crashes.
Change-Id: Ib543b69ab2f47fe38c4c8f62ba740f4bc7d8fbc5
---
M CMakeLists.txt
M src/kudu/cfile/cfile-test-base.h
M src/kudu/server/diagnostics_log.cc
M src/kudu/server/pprof_path_handlers.cc
M src/kudu/util/async_logger.cc
M src/kudu/util/async_logger.h
M src/kudu/util/debug-util.cc
M src/kudu/util/debug/trace_logging.h
M src/kudu/util/logging-test.cc
M src/kudu/util/logging.cc
M thirdparty/download-thirdparty.sh
A thirdparty/patches/glog-fix-demangle.patch
D thirdparty/patches/glog-make-internals-visible.patch
A thirdparty/patches/glog-make-symbolize-visible.patch
D thirdparty/patches/glog-support-stacktrace-for-aarch64.patch
M thirdparty/vars.sh
16 files changed, 101 insertions(+), 203 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/97/22097/1
--
To view, visit http://gerrit.cloudera.org:8080/22097
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib543b69ab2f47fe38c4c8f62ba740f4bc7d8fbc5
Gerrit-Change-Number: 22097
Gerrit-PatchSet: 1
Gerrit-Owner: Zoltan Martonka <[email protected]>
