Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22160 )
Change subject: [thirdparty] upgrade LZ4 up to 1.10.0 version ...................................................................... Patch Set 1: > Please take a look at the failed tests as I could not find them in > flaky test dashboard. I took a look at the dist-test results. For the ASAN build, there are failures of already known flaky tests -- you can see exactly the same errors at http://dist-test.cloudera.org:8080/test_drilldown?test_name=alter_table-test (ASAN) For RELEASE build, I took a look at KuduTxnsCliTest.TestBasicTxnsList. Even if it hasn't been failing recently in flaky test runs, I can see how it could fail -- the follow-up workload can generate rows with the same primary key, and that's confirmed by the comment for the default write pattern in TestWorkload: enum WritePattern { // The default: insert random row keys. This may cause an occasional // duplicate, but with 32-bit keys, they won't be frequent. INSERT_RANDOM_ROWS, ... } As for other tests, I guess that's something similar -- there are test-only bugs that don't manifest themselves often. I'm about to file a JIRA item at least for the KuduTxnsCliTest.TestBasicTxnsList test. I also built and ran ASAN-instrumented C++ tests locally on Ubuntu 20 machine with KUDU_ALLOW_SLOW_TESTS=1 a few times, and they passed. -- To view, visit http://gerrit.cloudera.org:8080/22160 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie1eff7e2977db007436ec82995cf30f3fd5472ca Gerrit-Change-Number: 22160 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 04 Dec 2024 06:05:21 +0000 Gerrit-HasComments: No
