Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22133 )
Change subject: KUDU-3571: fix flakiness in AutoIncrementingItest.BootstrapNoWalsNoData ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/22133/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22133/1//COMMIT_MSG@10 PS1, Line 10: om lagging replicas. This pat > I'm curious: what 'deterministic' means in this context? I can't speak to why limiting to only leader replica is concerning from the purpose of this test point of view. Abhishek may have more context there. Considering rows need to be up-to-date on all tablet replicas, I was suggesting to go with adjustment of heartbeat and sleep time (which as per your response doesn't seem to be appropriate) to ensure the rows are "replication complete" within that time. IIUC, leader does send updates right away but on peers, the update may take time upto FLAGS_raft_heartbeat_interval_ms duration. My understanding is based on the max wait time for replicated operations running on tablet replicas via UpdateReplica(): ++ s = log_synchronizer.WaitFor( MonoDelta::FromMilliseconds(FLAGS_raft_heartbeat_interval_ms)); ++ If there is no requirement of having all the replicas up-to-date and reading from leader replica is fine, PS1 approach should be fine. If not, WaitForServersToAgree() / AssertAllReplicasAgree() could also be explored. -- To view, visit http://gerrit.cloudera.org:8080/22133 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5bd387c82b632dbb77aa5a45f831273392ae05b4 Gerrit-Change-Number: 22133 Gerrit-PatchSet: 6 Gerrit-Owner: Yifan Zhang <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 04 Dec 2024 15:03:44 +0000 Gerrit-HasComments: Yes
