Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22171 )
Change subject: KUDU-3633 Threadpool shutdown before check ...................................................................... Patch Set 1: > I run the tests again, and it looks like it doesn't solve the > problem entirely, the check still fails sometimes. But it still > looks like it helps. Right: IIUC, there still might be tokens submitted, and shutting down a Threadpool instance doesn't process or clean them up. As I understand, the crucial point here is not about fixing how the presence of pending tasks is verified the Threadpool's destructor, but rather fixing the call site or an instance that leaves non-finished tasks when shutting down one of its Threadpool instances. -- To view, visit http://gerrit.cloudera.org:8080/22171 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iba1d2846e493a193a4dae31a0008fe6ca0817f62 Gerrit-Change-Number: 22171 Gerrit-PatchSet: 1 Gerrit-Owner: Ádám Bakai <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Reviewer: Ádám Bakai <[email protected]> Gerrit-Comment-Date: Thu, 12 Dec 2024 17:54:04 +0000 Gerrit-HasComments: No
