Abhishek Chennaka has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22170 )

Change subject: [thirdparty] KUDU-3626 update PostgreSQL and its JDBC driver
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/22170/5//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22170/5//COMMIT_MSG@7
PS5, Line 7: [thirdparty] KUDU-3626 update PostgreSQL and its JDBC driver
           :
> The summary is supposed to fit a single line.  Probably, this should be goo
Done


http://gerrit.cloudera.org:8080/#/c/22170/5//COMMIT_MSG@42
PS5, Line 42: Change-Id: I8693c0cecdc704f6ca1166af0fe14bc41256f629
> nit: add an empty line to separate the line with Change-Id ?
Done


http://gerrit.cloudera.org:8080/#/c/22170/5/thirdparty/build-definitions.sh
File thirdparty/build-definitions.sh:

http://gerrit.cloudera.org:8080/#/c/22170/5/thirdparty/build-definitions.sh@1175
PS5, Line 1175:
> nit: remove the trailing space
Done



--
To view, visit http://gerrit.cloudera.org:8080/22170
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I8693c0cecdc704f6ca1166af0fe14bc41256f629
Gerrit-Change-Number: 22170
Gerrit-PatchSet: 6
Gerrit-Owner: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Wed, 18 Dec 2024 18:14:06 +0000
Gerrit-HasComments: Yes

Reply via email to