Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22234 )
Change subject: KUDU-613: Micro-optimization in Erase() ...................................................................... KUDU-613: Micro-optimization in Erase() Prior to this patch, the Erase() function on the shard level did not have a return value. The Erase() function on the ShardPair level called both shard-level functions. This patch changes the shard-level Erase() function to return a bool to indicate whether an entry was erased. This allows the ShardPair level function to only call Erase() on the protected shard when the probationary shard does not find and erase the appropriate entry. Change-Id: I9941b671f00d5f4dd71b59a77b45f9cdbd79b367 Reviewed-on: http://gerrit.cloudera.org:8080/22229 Reviewed-by: Alexey Serbin <[email protected]> Tested-by: Alexey Serbin <[email protected]> (cherry picked from commit 5151270ea9d88bc40ad5ca2344c97f1eed5fadc9) Reviewed-on: http://gerrit.cloudera.org:8080/22234 --- M src/kudu/util/slru_cache.cc M src/kudu/util/slru_cache.h 2 files changed, 11 insertions(+), 4 deletions(-) Approvals: Alexey Serbin: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/22234 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.18.x Gerrit-MessageType: merged Gerrit-Change-Id: I9941b671f00d5f4dd71b59a77b45f9cdbd79b367 Gerrit-Change-Number: 22234 Gerrit-PatchSet: 2 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120)
