Mahesh Reddy has posted comments on this change. ( http://gerrit.cloudera.org:8080/22242 )
Change subject: Route authenticated principal into WebRequest ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/22242/1/src/kudu/server/webserver-test.cc File src/kudu/server/webserver-test.cc: http://gerrit.cloudera.org:8080/#/c/22242/1/src/kudu/server/webserver-test.cc@686 PS1, Line 686: StyleMode::UNSTYLED, nit: move this to the next line, and have it be at same indent as "/authn". Ex. server_->RegisterPrerenderedPathHandler("/authn", "AuthnWebserverTest", Handler, StyleMode::UNSTYLED, false); http://gerrit.cloudera.org:8080/#/c/22242/1/src/kudu/server/webserver-test.cc@694 PS1, Line 694: StyleMode::UNSTYLED, false); nit: same as above http://gerrit.cloudera.org:8080/#/c/22242/1/src/kudu/server/webserver.cc File src/kudu/server/webserver.cc: http://gerrit.cloudera.org:8080/#/c/22242/1/src/kudu/server/webserver.cc@675 PS1, Line 675: r nit: indent this line -- To view, visit http://gerrit.cloudera.org:8080/22242 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8a64fb77cfa3bb83b911afc3ebaa8bd23e860663 Gerrit-Change-Number: 22242 Gerrit-PatchSet: 1 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Thu, 19 Dec 2024 17:01:13 +0000 Gerrit-HasComments: Yes
