Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22233 )

Change subject: [test] Increase session timeout
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/22233/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/22233/1//COMMIT_MSG@9
PS1, Line 9: In TSAN build, sessions sometimes timed out.
Did you do any pre- and post-patch analysis of the test failure ratios?  I'm 
curious how many runs out of say, 1000 were failing before this patch and how 
many of 1000 fail now after this patch applied.  It's quite easy to implement 
if using dist-test.

BTW, I'd think that a better alternative in this case would be reducing the 
amount of generated data for ASAN/TSAN test runs.  Usually, we'd explore this 
approach first, and only if that's not possible by the nature of the test or by 
other reasons, we'd explore increasing timeouts as the last resort.  Do you 
think it would be possible to address the issue by reducing the number of 
inserted/updates rows just for ASAN/TSAN builds in this case as well?

Thank you!



--
To view, visit http://gerrit.cloudera.org:8080/22233
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I47f8b38aa3306eff77d61ac63f75f3b600606ae8
Gerrit-Change-Number: 22233
Gerrit-PatchSet: 1
Gerrit-Owner: Ádám Bakai <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Ádám Bakai <[email protected]>
Gerrit-Comment-Date: Fri, 20 Dec 2024 20:29:36 +0000
Gerrit-HasComments: Yes

Reply via email to