Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22239 )
Change subject: [tools] Run range aware cluster rebalance with multiple tables ...................................................................... Patch Set 4: Code-Review+2 (1 comment) Thank you for the patch! Overall it looks good to me, just a tiny nit in the newly added test. BTW, did you try to run the updated `kudu cluster rebalance` tool against a real cluster? http://gerrit.cloudera.org:8080/#/c/22239/4/src/kudu/tools/rebalancer_tool-test.cc File src/kudu/tools/rebalancer_tool-test.cc: http://gerrit.cloudera.org:8080/#/c/22239/4/src/kudu/tools/rebalancer_tool-test.cc@2407 PS4, Line 2407: ASSERT_EQ(table_names.size(), 1) nit for here and below: consider making the expected/reference to be the first argument of the ASSERT_EQ() macro -- if this assertion ever triggers, it will be easier to read the error message -- To view, visit http://gerrit.cloudera.org:8080/22239 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7f6995496e6c28e6a3a8fa4b6f0e8efd05335267 Gerrit-Change-Number: 22239 Gerrit-PatchSet: 4 Gerrit-Owner: Derek Huang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 21 Dec 2024 02:21:01 +0000 Gerrit-HasComments: Yes
