Ashwani Raina has posted comments on this change. ( http://gerrit.cloudera.org:8080/22279 )
Change subject: [thirdparty] fix building LLVM/CLANG 11.0.0 with GCC13 ...................................................................... Patch Set 1: (6 comments) Overall looks good to me. Just a few nits. http://gerrit.cloudera.org:8080/#/c/22279/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22279/1//COMMIT_MSG@15 PS1, Line 15: change nit: that http://gerrit.cloudera.org:8080/#/c/22279/1//COMMIT_MSG@16 PS1, Line 16: leaking in nit: leakage of http://gerrit.cloudera.org:8080/#/c/22279/1//COMMIT_MSG@17 PS1, Line 17: installed at the build machine nit: installed on the build machine nit: Maybe put under brackets or separate by commas. http://gerrit.cloudera.org:8080/#/c/22279/1//COMMIT_MSG@21 PS1, Line 21: codegen I guess we can confirm that by running multiple iterations of modified codegen test (TestCodeCache). I understand that the primary purpose of this change is not to address codegen/SLES issue, however, in case you need details on modified test, let me know. http://gerrit.cloudera.org:8080/#/c/22279/1//COMMIT_MSG@27 PS1, Line 27: Ubuntu 24.04 LTS Any other OS flavour (other than Ubuntu 24.04 LTS) where this patch is applicable, considering default GCC version as 13? http://gerrit.cloudera.org:8080/#/c/22279/1//COMMIT_MSG@29 PS1, Line 29: a an -- To view, visit http://gerrit.cloudera.org:8080/22279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b8282c85bbac5f25eae885e4b3ec183104bc540 Gerrit-Change-Number: 22279 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Mon, 30 Dec 2024 13:16:58 +0000 Gerrit-HasComments: Yes
