Marton Greber has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22278 )
Change subject: [thirdparty] fix building breakpad with GCC13 ...................................................................... [thirdparty] fix building breakpad with GCC13 GCC13 (G++13) is the default system compiler on contemporary Linux OS flavors such as Ubuntu 24.04 LTS. With this patch it's now possible to compile breakpad on Ubuntu 24.04 LTS. This patch picks up a few relevant patches from the breakpad's upstream repository [1]. Probably, it's time to refresh breakpad with the latest snapshot from [1] to bring in numerous fixes (especially for AArch64), but I think it's better doing so in a separate patch. [1] https://chromium.googlesource.com/breakpad/breakpad Change-Id: I95c1bb8a2361c94f40b8b76b7f57159946b15a15 Reviewed-on: http://gerrit.cloudera.org:8080/22278 Reviewed-by: Marton Greber <[email protected]> Tested-by: Marton Greber <[email protected]> Reviewed-by: Gabriella Lotz <[email protected]> --- M thirdparty/download-thirdparty.sh M thirdparty/patches/breakpad-SIGSTKSZ-error.patch A thirdparty/patches/breakpad-fclose.patch A thirdparty/patches/breakpad-fread.patch A thirdparty/patches/breakpad-guid-creator.patch A thirdparty/patches/breakpad-minidump-descriptor.patch 6 files changed, 144 insertions(+), 6 deletions(-) Approvals: Marton Greber: Looks good to me, approved; Verified Gabriella Lotz: Looks good to me, but someone else must approve -- To view, visit http://gerrit.cloudera.org:8080/22278 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I95c1bb8a2361c94f40b8b76b7f57159946b15a15 Gerrit-Change-Number: 22278 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]>
