Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22279 )
Change subject: [thirdparty] fix building LLVM/CLANG 11.0.0 with GCC13 ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/22279/3/thirdparty/download-thirdparty.sh File thirdparty/download-thirdparty.sh: http://gerrit.cloudera.org:8080/#/c/22279/3/thirdparty/download-thirdparty.sh@495 PS3, Line 495: $ROCKSDB_NAME.tar.gz \ : $ROCKSDB_SOURCE \ : $ROCKSDB_PATCHLEVEL \ : "patch -p1 < $TP_DIR/patches/rocksdb-gcc13.patch" > nit: Correct the indentation Sure -- I will do so in a separate patch. As you can see, (a) these lines are unrelated to the scope of this patch, and (b) there are different indentation for different components, so it's better to unify that, if going the route of addressing nits like this. -- To view, visit http://gerrit.cloudera.org:8080/22279 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b8282c85bbac5f25eae885e4b3ec183104bc540 Gerrit-Change-Number: 22279 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Comment-Date: Wed, 22 Jan 2025 06:42:26 +0000 Gerrit-HasComments: Yes
