Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22428 )
Change subject: [maintenance_manager] micro-optimisation on LogPrefix ...................................................................... [maintenance_manager] micro-optimisation on LogPrefix There is just a single instance of MaintenanceManager per Kudu server, so it makes sense to store its log prefix as a field and avoid allocating memory and constructing the string every time a log message is issued. This patch doesn't contain any functional modifications. Change-Id: I40398106af386eb352cef05df7644941a230a468 Reviewed-on: http://gerrit.cloudera.org:8080/22428 Reviewed-by: Ashwani Raina <[email protected]> Reviewed-by: Mahesh Reddy <[email protected]> Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Yifan Zhang <[email protected]> --- M src/kudu/util/maintenance_manager.cc M src/kudu/util/maintenance_manager.h 2 files changed, 5 insertions(+), 5 deletions(-) Approvals: Ashwani Raina: Looks good to me, but someone else must approve Mahesh Reddy: Looks good to me, but someone else must approve Alexey Serbin: Verified Yifan Zhang: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22428 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I40398106af386eb352cef05df7644941a230a468 Gerrit-Change-Number: 22428 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Ashwani Raina <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]>
