Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22373 )
Change subject: [thirdparty] Upgrade protobuf to 3.21.9 ...................................................................... Patch Set 14: Code-Review+2 (4 comments) http://gerrit.cloudera.org:8080/#/c/22373/14//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22373/14//COMMIT_MSG@23 PS14, Line 23: [4] nit: could you add rather a permalink instead? If the code in that file changes in the 21.x branch, this will start pointing to a wrong place http://gerrit.cloudera.org:8080/#/c/22373/14//COMMIT_MSG@25 PS14, Line 25: 6] nit: ditto http://gerrit.cloudera.org:8080/#/c/22373/14/src/kudu/tools/tool_action_table.cc File src/kudu/tools/tool_action_table.cc: http://gerrit.cloudera.org:8080/#/c/22373/14/src/kudu/tools/tool_action_table.cc@34 PS14, Line 34: // IWYU pragma: keep nit: is this pragma still necessary? http://gerrit.cloudera.org:8080/#/c/22373/14/src/kudu/tools/tool_action_test.cc File src/kudu/tools/tool_action_test.cc: http://gerrit.cloudera.org:8080/#/c/22373/14/src/kudu/tools/tool_action_test.cc@31 PS14, Line 31: // IWYU pragma: keep nit: is this pragma still necessary? -- To view, visit http://gerrit.cloudera.org:8080/22373 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5274c5f4c681a864d126c51960fa3b41d4f568d7 Gerrit-Change-Number: 22373 Gerrit-PatchSet: 14 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 07 Feb 2025 23:30:57 +0000 Gerrit-HasComments: Yes
