Gabriella Lotz has posted comments on this change. ( http://gerrit.cloudera.org:8080/22420 )
Change subject: KUDU-3639 Add REST-compatible table operation functions ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/22420/6/src/kudu/master/catalog_manager-test.cc File src/kudu/master/catalog_manager-test.cc: http://gerrit.cloudera.org:8080/#/c/22420/6/src/kudu/master/catalog_manager-test.cc@277 PS6, Line 277: CatalogManagerRpcA > Please rename the test class to reflect whats the purpose of this test. Done http://gerrit.cloudera.org:8080/#/c/22420/6/src/kudu/master/catalog_manager-test.cc@316 PS6, Line 316: c void Populate > Please rename this function as is can be confusing to have a CreateTestTabl Done http://gerrit.cloudera.org:8080/#/c/22420/6/src/kudu/master/catalog_manager-test.cc@316 PS6, Line 316: bleRequestPB* req) { > if not used in the function, you can remove this argument. Done http://gerrit.cloudera.org:8080/#/c/22420/6/src/kudu/master/catalog_manager.cc File src/kudu/master/catalog_manager.cc: http://gerrit.cloudera.org:8080/#/c/22420/6/src/kudu/master/catalog_manager.cc@2233 PS6, Line 2233: } : : // Create a new table. : Status CatalogManager::CreateTableWithUser(const CreateTableRequestPB* orig_req, : CreateTableResponsePB* resp, : const optional<stri > nit: Done -- To view, visit http://gerrit.cloudera.org:8080/22420 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If52359603e3aa8af2dedc41ecc5eb78d03151fe5 Gerrit-Change-Number: 22420 Gerrit-PatchSet: 7 Gerrit-Owner: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Gabriella Lotz <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Tue, 11 Feb 2025 08:54:30 +0000 Gerrit-HasComments: Yes
