Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22478 )
Change subject: KUDU-613: Fix BlockCache Constructor ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22478/1/src/kudu/cfile/block_cache.cc File src/kudu/cfile/block_cache.cc: http://gerrit.cloudera.org:8080/#/c/22478/1/src/kudu/cfile/block_cache.cc@253 PS1, Line 253: static_cast<int> What if the result number before this cast here and below is greater than 2^31 (e.g. 2GiB)? Isn't this just another bug? BTW, casting a double/float to an integer doesn't always provide the desired result for huge values, but it seems this isn't a problem in this particular case. But it should provide some extra context if you are about to address the issue pointed above. -- To view, visit http://gerrit.cloudera.org:8080/22478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfde56fd766ba7160052e88ca09a63845f3297c6 Gerrit-Change-Number: 22478 Gerrit-PatchSet: 1 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Wed, 12 Feb 2025 07:45:28 +0000 Gerrit-HasComments: Yes
