Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22478 )
Change subject: KUDU-613: Fix BlockCache Constructor ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/22478/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22478/1//COMMIT_MSG@11 PS1, Line 11: policy. This patch fixes this miscalculation. : > I added a DCHECK_EQ statement for now. I had some trouble accessing the pri Yes, I think it's good enough now: by my understanding, with having DCHECK_EQ() as of PS3, we should have been able to caught a bug like this. Thank you for adding that! -- To view, visit http://gerrit.cloudera.org:8080/22478 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icfde56fd766ba7160052e88ca09a63845f3297c6 Gerrit-Change-Number: 22478 Gerrit-PatchSet: 3 Gerrit-Owner: Mahesh Reddy <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mahesh Reddy <[email protected]> Gerrit-Comment-Date: Thu, 13 Feb 2025 19:31:06 +0000 Gerrit-HasComments: Yes
