Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/22489
Change subject: [cmake] add -Werror=unused-result flag ...................................................................... [cmake] add -Werror=unused-result flag This is to help catching issues with improper handling of return values from functions/methods having the [[nodiscard]] attribute or WARN_UNUSED_RESULT macro. In addition, one warning that appeared after upgrading protobuf is now addressed. Since the new protobuf marks some of the auto-generated methods with the [[nodiscard]] attribute, there was an extra warning that might have pointed to a possible memory leak. That wasn't the case because of the Log::AsyncAppendReplicates() method's semantics, but it's worth paying it extra attention anyway. Change-Id: Ieb655d14973238960d48ebbd282e77ad91c57122 --- M CMakeLists.txt M src/kudu/consensus/log.cc 2 files changed, 5 insertions(+), 1 deletion(-) git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/22489/1 -- To view, visit http://gerrit.cloudera.org:8080/22489 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: newchange Gerrit-Change-Id: Ieb655d14973238960d48ebbd282e77ad91c57122 Gerrit-Change-Number: 22489 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]>
