Abhishek Chennaka has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22505 )
Change subject: [consensus] address warning on released replicates ...................................................................... [consensus] address warning on released replicates This patch addresses a warning that appeared after upgrading protobuf to version 3.21.9. Since the new protobuf marks some of the auto-generated methods with the [[nodiscard]] attribute, there was an extra warning that might have pointed to a possible memory leak. It wasn't the case because of the Log::AsyncAppendReplicates() method's semantics, but it's worth addressing it anyway. Change-Id: Ia756597b920622baef8c55b5040d6c051814db63 Reviewed-on: http://gerrit.cloudera.org:8080/22505 Tested-by: Alexey Serbin <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> --- M src/kudu/consensus/log.cc 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Alexey Serbin: Verified Abhishek Chennaka: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/22505 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ia756597b920622baef8c55b5040d6c051814db63 Gerrit-Change-Number: 22505 Gerrit-PatchSet: 3 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]>
