Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/22534 )
Change subject: [thirdparty] fix building LLVM+IWYU on ARM
......................................................................
[thirdparty] fix building LLVM+IWYU on ARM
There had been an issue with building IWYU in-tree with LLVM for non-X86
platforms that was addressed upstream by [1]. It's necessary to add
that patch into Kudu's 3rd-party to fix building LLVM on ARM after [2].
Without the extra patch for IWYU's top-level CMakeLists.txt, building
Kudu's 3rd-party on ARM produces an error like below after [2]:
The error looked like the following:
-- IWYU: in-tree configuration
-- IWYU: configuring for LLVM 11.0.0...
CMake Error at cmake/modules/LLVM-Config.cmake:274 (message):
Library 'X86AsmParser' is a direct reference to a target library for an
omitted target.
Call Stack (most recent call first):
cmake/modules/LLVM-Config.cmake:100 (llvm_map_components_to_libnames)
cmake/modules/LLVM-Config.cmake:93 (explicit_llvm_config)
cmake/modules/AddLLVM.cmake:867 (llvm_config)
tools/clang/tools/include-what-you-use/CMakeLists.txt:49
(add_llvm_executable)
This is a follow-up to [2].
[1]
https://github.com/include-what-you-use/include-what-you-use/commit/718e69875
[2] https://github.com/apache/kudu/commit/de9a0370e
Change-Id: If24fcf01079918d951278237241edb60610f5927
Reviewed-on: http://gerrit.cloudera.org:8080/22534
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Abhishek Chennaka <[email protected]>
---
M thirdparty/download-thirdparty.sh
A thirdparty/patches/llvm-iwyu-718e69875.patch
2 files changed, 36 insertions(+), 1 deletion(-)
Approvals:
Alexey Serbin: Verified
Abhishek Chennaka: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22534
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: If24fcf01079918d951278237241edb60610f5927
Gerrit-Change-Number: 22534
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yan-Daojiang <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
