Alexey Serbin has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/22514 )
Change subject: [util] fix result status handling
......................................................................
[util] fix result status handling
This patch addresses sloppy result handling of functions/methods
that return Status under the src/kudu/util directory and in one
related test in src/kudu/server/webserver-test.cc
The updated call sites are are mostly in the test code, but there are
a few in src/kudu/util/thread.{cc,h} and in src/kudu/util/env_posix.cc,
where the fix in the latter is the most impactful.
Change-Id: Ic5dc4ebc07dca668cd33f4b83c55d4354748b937
Reviewed-on: http://gerrit.cloudera.org:8080/22514
Tested-by: Alexey Serbin <[email protected]>
Reviewed-by: Marton Greber <[email protected]>
---
M src/kudu/server/webserver-test.cc
M src/kudu/util/block_bloom_filter-test.cc
M src/kudu/util/char_util-test.cc
M src/kudu/util/compression/compression-test.cc
M src/kudu/util/curl_util-test.cc
M src/kudu/util/curl_util.h
M src/kudu/util/debug-util-test.cc
M src/kudu/util/env-test.cc
M src/kudu/util/env_posix.cc
M src/kudu/util/file_cache-test.cc
M src/kudu/util/maintenance_manager-test.cc
M src/kudu/util/net/net_util.cc
M src/kudu/util/once-test.cc
M src/kudu/util/pb_util-test.cc
M src/kudu/util/pb_util.cc
M src/kudu/util/thread.cc
M src/kudu/util/thread.h
M src/kudu/util/threadpool.cc
M src/kudu/util/threadpool.h
19 files changed, 73 insertions(+), 50 deletions(-)
Approvals:
Alexey Serbin: Verified
Marton Greber: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/22514
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5dc4ebc07dca668cd33f4b83c55d4354748b937
Gerrit-Change-Number: 22514
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Yifan Zhang <[email protected]>
