Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22509 )
Change subject: [util] fix MetricsTest.TableAndTabletPrometheusTest ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/22509/1/src/kudu/util/metrics-test.cc File src/kudu/util/metrics-test.cc: http://gerrit.cloudera.org:8080/#/c/22509/1/src/kudu/util/metrics-test.cc@158 PS1, Line 158: 1111111111 > I see, makes sense. Maybe leave one at 32 character length? Just in case th Yes, that's a valid concern. And to address it there should be a test scenario for corner cases, as discussed. Just to be clear: this particular test scenario isn't able catch an issue with Kudu metrics names being too long for Prometheus, and it wasn't able to catch that before this patch either. Anyway, I added an extra table entity to have 32-symbol length name, as requested. I'm not quite sure what it is for, but probably you have some extra concerns beyond those you've already articulated in prior comments. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/22509 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15ee5fc8974f5df931a33cdcbc09c3da4da691a7 Gerrit-Change-Number: 22509 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Wed, 26 Feb 2025 05:54:56 +0000 Gerrit-HasComments: Yes
