Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies ...................................................................... Patch Set 17: -Code-Review (2 comments) http://gerrit.cloudera.org:8080/#/c/22374/17/build-support/verify_jars.pl File build-support/verify_jars.pl: http://gerrit.cloudera.org:8080/#/c/22374/17/build-support/verify_jars.pl@62 PS17, Line 62: META-INF/versions/9/module-info.class > Isn't this a fluke/bug? Why module-info.class is under the versioned MRJAR I ran the verify_jars.py after building the java project with JDK8, however it still throws errors[0], so this is insufficient. Instead of adding this here, maybe try excluding the Java9 versioned classes altogether from the kudu-hive dependencies? [0]: $>: ../build-support/verify_jars.pl . Checking jars in directory: /Users/zchovan/CLionProjects/kudu/java > ./kudu-backup/build/libs/kudu-backup3_2.12-1.18.0-SNAPSHOT.jar > ./kudu-client/build/libs/kudu-client-1.18.0-SNAPSHOT.jar > ./kudu-proto/build/libs/kudu-proto-1.18.0-SNAPSHOT.jar > ./kudu-spark-tools/build/libs/kudu-spark3-tools_2.12-1.18.0-SNAPSHOT.jar > ./kudu-hive/build/libs/kudu-hive-1.18.0-SNAPSHOT.jar NON_KUDU avro/shaded/com/google/common/collect/package-info.class NON_KUDU avro/shaded/com/google/common/cache/package-info.class NON_KUDU avro/shaded/com/google/common/base/package-info.class NON_KUDU avro/shaded/com/google/common/math/package-info.class NON_KUDU avro/shaded/com/google/common/primitives/package-info.class NON_KUDU avro/shaded/com/google/common/util/concurrent/package-info.class NON_JAVA META-INF/LICENSE.md NON_JAVA META-INF/NOTICE.md NON_KUDU META-INF/versions/9/javax/xml/bind/ModuleUtil.class > ./kudu-spark/build/libs/kudu-spark3_2.12-1.18.0-SNAPSHOT.jar > ./kudu-test-utils/build/libs/kudu-test-utils-1.18.0-SNAPSHOT.jar > ./kudu-backup-common/build/libs/kudu-backup-common-1.18.0-SNAPSHOT.jar http://gerrit.cloudera.org:8080/#/c/22374/17/java/kudu-hive/build.gradle File java/kudu-hive/build.gradle: http://gerrit.cloudera.org:8080/#/c/22374/17/java/kudu-hive/build.gradle@26 PS17, Line 26: testImplementation > Are you sure that's not needed in regular (i.e. not just test) runtime? +1 on Alexey's question, the original compiles just fine. -- To view, visit http://gerrit.cloudera.org:8080/22374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d Gerrit-Change-Number: 22374 Gerrit-PatchSet: 17 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Thu, 27 Feb 2025 08:53:30 +0000 Gerrit-HasComments: Yes
