Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/22515 )
Change subject: fix(test): ensure proper alignment of `version_` in `NodeBase` on ARM64 ...................................................................... Patch Set 3: NodeBase should be aligned to 8 bytes (sizeof(AtomicVersion)). Nodes are always aligned. We also store non-aligned data between them. Look at the NewLeaf and NewInternalNode functions. The arena_->AllocateBytesAligned(...) call should guarantee it. Removing the PACKED attribute has a measurable performance impact. If the test still fails on the version Alexey mentioned, could you please test if the "mem" local variable in these two functions is aligned? Also, if the issue is still present in the new version, could you tell me what OS/compiler/architecture you are using? -- To view, visit http://gerrit.cloudera.org:8080/22515 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id082d3ca243418d4f0016fbd21a59ead0fa9dfc5 Gerrit-Change-Number: 22515 Gerrit-PatchSet: 3 Gerrit-Owner: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yan-Daojiang <[email protected]> Gerrit-Reviewer: Zoltan Martonka <[email protected]> Gerrit-Comment-Date: Thu, 27 Feb 2025 13:52:53 +0000 Gerrit-HasComments: No
