Zoltan Chovan has posted comments on this change. ( http://gerrit.cloudera.org:8080/22563 )
Change subject: [common] fix result status handling ...................................................................... Patch Set 2: > Patch Set 2: > > > > Patch Set 2: Code-Review+1 > > > > > > Would it make sense to add WARN_UNUSED_RESULT to the PartialRow > > methods? (probably in a separate changelist) > > > > Sorry, I just saw, https://gerrit.cloudera.org/c/22489/, do these > > fixes come from the result of adding '-Werror=unused-result'? > > No. You missed this one: https://gerrit.cloudera.org/#/c/22504/ Makes more sense, thanks for the explanation! -- To view, visit http://gerrit.cloudera.org:8080/22563 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8bf6de64284e4097ac18e56e282c81dea3d52544 Gerrit-Change-Number: 22563 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 04 Mar 2025 08:03:20 +0000 Gerrit-HasComments: No
