Hello Marton Greber, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22568
to look at the new patch set (#3).
Change subject: KUDU-3647 more robust zlib wrapper code
......................................................................
KUDU-3647 more robust zlib wrapper code
This patch updates zlib::CompressLevel() and zlib::Uncompress() to have
more robust error handling and fixes the bug introduced along with other
modifications in [1]. In addition, zlib::CompressLevel() no longer
allocates memory on the heap and is now closer to the documented
API of deflate() per zlib's docs [2] and code example [3]. This patch
also adds a test for both zlib::{CompressLevel,Uncompress}() utility
wrappers to cover their functionality and handling error conditions in
zlib::Uncompress() attributed to truncated and corrupted input data.
[1] https://issues.apache.org/jira/browse/KUDU-3201
[2] https://zlib.net/zlib_how.html
[3] https://zlib.net/zpipe.c
Change-Id: I5babcaf0a07c284d44f16201aa765e277b6464d3
---
M src/kudu/util/CMakeLists.txt
A src/kudu/util/zlib-test.cc
M src/kudu/util/zlib.cc
M src/kudu/util/zlib.h
4 files changed, 236 insertions(+), 37 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/68/22568/3
--
To view, visit http://gerrit.cloudera.org:8080/22568
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5babcaf0a07c284d44f16201aa765e277b6464d3
Gerrit-Change-Number: 22568
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
