Hello Marton Greber, Alexey Serbin, Attila Bukor, Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/22589
to look at the new patch set (#2).
Change subject: [java] Modernise codebase
......................................................................
[java] Modernise codebase
While reviewing the java code, I noticed that there are many instances
where not even Java 8 features are used, in this particular case: lambdas.
This change replaces many instances of unnecessary boilerplate (anonymous
methods and classes), and in a few cases replaces the ThreadLocal
initialisation with 'ThreadLocal.withInitial()'. The intent is to improve
code readability, so a few places[0][1] where lambdas could've been used, but
only with worse readability, the code was left as is. Also where possible,
lambdas were replaced by method references.
There are no functional changes, so no new tests are introduced.
[0]
https://github.com/apache/kudu/blob/master/java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java#L116
[1]
https://github.com/apache/kudu/blob/master/java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java#L148
// both of these would result in something like () -> () -> {..}
Change-Id: Ice41e86c666e7589662ec0c5ffa0b0e7dd493a98
---
M java/kudu-client/src/main/java/org/apache/kudu/client/AsyncKuduSession.java
M java/kudu-client/src/main/java/org/apache/kudu/client/ConnectToCluster.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Connection.java
M java/kudu-client/src/main/java/org/apache/kudu/client/KuduPredicate.java
M java/kudu-client/src/main/java/org/apache/kudu/client/Negotiator.java
M java/kudu-client/src/main/java/org/apache/kudu/client/RpcProxy.java
M java/kudu-client/src/main/java/org/apache/kudu/util/Slices.java
M java/kudu-client/src/main/java/org/apache/kudu/util/TimestampUtil.java
M java/kudu-client/src/test/java/org/apache/kudu/TestColumnSchema.java
M java/kudu-client/src/test/java/org/apache/kudu/client/ITClientStress.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestAlterTable.java
M
java/kudu-client/src/test/java/org/apache/kudu/client/TestAuthTokenReacquire.java
M
java/kudu-client/src/test/java/org/apache/kudu/client/TestClientFailoverSupport.java
M
java/kudu-client/src/test/java/org/apache/kudu/client/TestFlexiblePartitioning.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestHandleTooBusy.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduClient.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduScanner.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduTransaction.java
M
java/kudu-client/src/test/java/org/apache/kudu/client/TestMultiMasterAuthzTokens.java
M
java/kudu-client/src/test/java/org/apache/kudu/client/TestMultipleLeaderFailover.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestNegotiation.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestRequestTracker.java
M java/kudu-client/src/test/java/org/apache/kudu/client/TestSecurity.java
M
java/kudu-subprocess/src/test/java/org/apache/kudu/subprocess/TestMessageIO.java
M
java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingLogAppender.java
M
java/kudu-test-utils/src/main/java/org/apache/kudu/test/CapturingToFileLogAppender.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/ClientTestUtil.java
M java/kudu-test-utils/src/main/java/org/apache/kudu/test/TempDirUtils.java
M
java/kudu-test-utils/src/test/java/org/apache/kudu/test/TestMiniKuduCluster.java
29 files changed, 359 insertions(+), 577 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/89/22589/2
--
To view, visit http://gerrit.cloudera.org:8080/22589
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ice41e86c666e7589662ec0c5ffa0b0e7dd493a98
Gerrit-Change-Number: 22589
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Chovan <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Attila Bukor <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <[email protected]>
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
