Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/22594 )
Change subject: [util] use ZBEST_SPEED for zlib::Compress() ...................................................................... [util] use ZBEST_SPEED for zlib::Compress() The only non-test call site for zlib::CompressLevel() is in embedded web server, where ZBEST_SPEED compression level is used. From the other side, tracing path handlers is the only non-test call site place where zlib::Compress() is used. The latter seems to benefit the same way as the former if switching from Z_DEFAULT_COMPRESSION to ZBEST_SPEED compression level in [1]. In other words, it makes sense to switch zlib::Compress() from Z_DEFAULT_COMPRESSION to ZBEST_SPEED and use zlib::Compress() everywhere. This patch does exactly so. [1] https://github.com/apache/kudu/commit/9106a3ca8 Change-Id: Ib2541a8785cff776fc9e8a6df23c2f44e77fdc5b Reviewed-on: http://gerrit.cloudera.org:8080/22594 Reviewed-by: Yifan Zhang <[email protected]> Reviewed-by: Abhishek Chennaka <[email protected]> Tested-by: Alexey Serbin <[email protected]> --- M src/kudu/server/webserver.cc M src/kudu/util/zlib.cc M src/kudu/util/zlib.h 3 files changed, 5 insertions(+), 3 deletions(-) Approvals: Yifan Zhang: Looks good to me, approved Abhishek Chennaka: Looks good to me, approved Alexey Serbin: Verified -- To view, visit http://gerrit.cloudera.org:8080/22594 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Ib2541a8785cff776fc9e8a6df23c2f44e77fdc5b Gerrit-Change-Number: 22594 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]>
