Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22614 )
Change subject: [util] introduce ThreadPoolToken::Close() ...................................................................... Patch Set 6: (1 comment) http://gerrit.cloudera.org:8080/#/c/22614/6/src/kudu/util/threadpool.cc File src/kudu/util/threadpool.cc: http://gerrit.cloudera.org:8080/#/c/22614/6/src/kudu/util/threadpool.cc@344 PS6, Line 344: CHECK_GT(active_threads_, 0) > Does this check needs to be applied for GRACEFUL_QUIESCING state too? Yes, we can add a check for GRACEFUL_QUESCING as well. -- To view, visit http://gerrit.cloudera.org:8080/22614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic226319c191af666233ec735c1787389d051b039 Gerrit-Change-Number: 22614 Gerrit-PatchSet: 6 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 14 Mar 2025 23:14:04 +0000 Gerrit-HasComments: Yes
