Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22374 )
Change subject: Upgrade Java dependencies ...................................................................... Patch Set 20: (2 comments) http://gerrit.cloudera.org:8080/#/c/22374/20//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/22374/20//COMMIT_MSG@44 PS20, Line 44: Changes in shadow.gradle: : Excluding classes with Java21 as Gradle 7 doesn't recognize them. : Excluding Java9 version specific classes(module-info.class) as we compile with : Java8 and don't need them anyway. : Excluding bouncycastle due to [2] : : [1] https://issues.apache.org/jira/browse/MAPREDUCE-7471 : [2] https://github.com/apache/hadoop/blob/4d7825309348956336b8f06a0 Could you please in-line this information into the shadow.gradle file itself? That way it's much easier to track and comprehend the reasoning of having particular rules there. It should help in future when updating the shadowing rules, when necessary. http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle File java/kudu-hive/build.gradle: http://gerrit.cloudera.org:8080/#/c/22374/20/java/kudu-hive/build.gradle@37 PS20, Line 37: // Hive Metastore uses hadoop-common-3.10.1 which seems to be having issues finding the correct : // classpath for org.apache.hadoop.fs.BatchListingOperations. This is a workaround to force the : // version which we use for hadoop-common which is said to be compatible with the current Hive : // metastore version according to official Hive documentation: : // https://hive.apache.org/general/downloads/ : : configurations.all { : resolutionStrategy { : force libs.hadoopCommon : } : } This looks a bit strange. Should we then remove this and the two packages that were added as dependencies at lines 26-27 (libs.hadoopCommon and libs.hadoopMRClientCommon)? At least, I was able to successfully run './gradlew assemble' locally after removing those. -- To view, visit http://gerrit.cloudera.org:8080/22374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id1b43e3cc8228e94fbbd3085933cd62bf089e23d Gerrit-Change-Number: 22374 Gerrit-PatchSet: 20 Gerrit-Owner: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Tue, 18 Mar 2025 19:03:08 +0000 Gerrit-HasComments: Yes
