Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22654 )
Change subject: [postgres] fix result status handling ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22654/2/src/kudu/ranger/ranger_client-test.cc File src/kudu/ranger/ranger_client-test.cc: http://gerrit.cloudera.org:8080/#/c/22654/2/src/kudu/ranger/ranger_client-test.cc@439 PS2, Line 439: ASSERT_DEATH({ ASSERT_OK(InitializeRanger()); }, > This seems so weird, I would've assumed that InitializeRanger() would never It's the same as with many other ASSERT_DEATH() or EXPECT_DEATH() blocks in the Kudu's codebase. Here, with just a single line in the block, this this means the control never reaches the point where the function returns from InitializeRanger(). It might be ignore_result(...) instead of ASSERT_OK(...), but it wouldn't change anything: it should crash anyway, otherwise an assertion will be triggered by ASSERT_DEATH(). Let me know if you think ignore_result(...) would be more appropriate here instead of ASSERT_OK(...) -- To view, visit http://gerrit.cloudera.org:8080/22654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib19efded15db30c5f3ddaed3e3d5a3f6d98fad1b Gerrit-Change-Number: 22654 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Marton Greber <[email protected]> Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Reviewer: Zoltan Chovan <[email protected]> Gerrit-Comment-Date: Mon, 24 Mar 2025 15:39:22 +0000 Gerrit-HasComments: Yes
