Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22646 )
Change subject: [consensus] fix result status handling ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/22646/2/src/kudu/consensus/pending_rounds.cc File src/kudu/consensus/pending_rounds.cc: http://gerrit.cloudera.org:8080/#/c/22646/2/src/kudu/consensus/pending_rounds.cc@41 PS2, Line 41: raft_allow_committed_pending_index_gap > Do we want to mark it unsafe as well? That's a good point, indeed: tagging it 'unsafe' corresponds to the semantics of this flag, and unsafe flags are automatically hidden from the auto-generated documentation. Thanks! -- To view, visit http://gerrit.cloudera.org:8080/22646 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6db113c58c6b453bf3cd290ee0dfdd184b63b999 Gerrit-Change-Number: 22646 Gerrit-PatchSet: 2 Gerrit-Owner: Alexey Serbin <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Yifan Zhang <[email protected]> Gerrit-Comment-Date: Fri, 21 Mar 2025 06:09:51 +0000 Gerrit-HasComments: Yes
