Zoltan Chovan has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/22713 )

Change subject: Gcovr support with coverage post-processing
......................................................................


Patch Set 2: Code-Review+1

(2 comments)

Thanks for this patch! Small nits, but overall looks good

http://gerrit.cloudera.org:8080/#/c/22713/2/build-support/jenkins/build-and-test.sh
File build-support/jenkins/build-and-test.sh:

http://gerrit.cloudera.org:8080/#/c/22713/2/build-support/jenkins/build-and-test.sh@552
PS2, Line 552: integartion
is this a typo?


http://gerrit.cloudera.org:8080/#/c/22713/2/build-support/process_gcovr_report.py
File build-support/process_gcovr_report.py:

http://gerrit.cloudera.org:8080/#/c/22713/2/build-support/process_gcovr_report.py@69
PS2, Line 69: soup
could we rename this to something else? reading soup.findAll is a bit weird to 
me :D



--
To view, visit http://gerrit.cloudera.org:8080/22713
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9d08cbb03234ec97cda985a35ac1b10a5d28ca20
Gerrit-Change-Number: 22713
Gerrit-PatchSet: 2
Gerrit-Owner: Marton Greber <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Chovan <[email protected]>
Gerrit-Comment-Date: Mon, 31 Mar 2025 11:20:59 +0000
Gerrit-HasComments: Yes

Reply via email to